Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing upstream name in gateway-api routes #1754

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

lingsamuel
Copy link
Member

Type of change:

  • Bugfix

What this PR does / why we need it:

Bugfix: should set upstream.Name since TranslateContext use it as the key. Otherwise, the generated upstream will be ignored.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@tao12345666333 tao12345666333 added area/controller bug Something isn't working labels Mar 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

Merging #1754 (613ff61) into master (c5b2ae8) will increase coverage by 0.03%.
The diff coverage is 63.63%.

❗ Current head 613ff61 differs from pull request most recent head bed677e. Consider uploading reports for the commit bed677e to get more accurate results

@@            Coverage Diff             @@
##           master    #1754      +/-   ##
==========================================
+ Coverage   41.69%   41.72%   +0.03%     
==========================================
  Files          90       90              
  Lines        7702     7707       +5     
==========================================
+ Hits         3211     3216       +5     
  Misses       4127     4127              
  Partials      364      364              
Impacted Files Coverage Δ
.../providers/gateway/translation/gateway_tlsroute.go 0.00% <0.00%> (ø)
.../providers/gateway/translation/gateway_udproute.go 0.00% <0.00%> (ø)
...providers/gateway/translation/gateway_httproute.go 49.54% <100.00%> (+1.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tao12345666333 tao12345666333 added this to the v1.7.0 milestone Mar 30, 2023
@lingsamuel lingsamuel merged commit 7ccf531 into apache:master Mar 30, 2023
lingsamuel added a commit to lingsamuel/apisix-ingress-controller that referenced this pull request Mar 31, 2023
* fix: missing upstream name in gateway-api routes

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>

* fmt imports

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>

---------

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
lingsamuel added a commit that referenced this pull request Mar 31, 2023
* fix: missing upstream name in gateway-api routes



* fmt imports



---------

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants