Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created a new folder named ambari-web-vite #3931

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

81163954
Copy link

What changes were proposed in this pull request?

Created a new folder named ambari-web-vite in ambari-web,The goal is to use Vite to proxy Ambari Web.
The process is as follows: First, use Brunch to build the public folder in Ambari Web, and then use Vite to directly start the Ambari Web project in ambari-web-vite.

@JiaLiangC
Copy link
Contributor

@zRains Could you help review this?

@zRains
Copy link
Contributor

zRains commented Jan 20, 2025

Thanks for your work and for providing a solid idea for developing ambari-web. However, IMO, what we need is a simple proxy server. For Vite, the ideal choice should be node-http-proxy. But in your code, you've included the initialization of a Vite project, and some of the resources there won’t actually be used—like the CSS files.

This kind of separated development environment increases debugging costs, so it’s more suitable for early, non-optimized DEV. Later on, I’d recommend replacing Brunch with Vite. This way, we can make better use of Vite’s features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants