Use strict API schemas

[mik-laj]

The rules are already verified by connexion, but it's still worth forcing some unexpected errors to not be accidentally ignored.

    :param bool strict: If `True`, raise errors if invalid data are passed in
        instead of failing silently and storing the errors.

CC: @ephraimbuddy

---

Make sure to mark the boxes below before creating PR: [x]

• Description above provides context of the change
• Unit tests coverage for changes (not needed for documentation changes)
• Target Github ISSUE in description if exists
• Commits follow "How to write a good git commit message"
• Relevant documentation is updated including usage instructions.
• I will engage committers as explained in Contribution Workflow Example.

---

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

[ephraimbuddy]

Nice!

[ephraimbuddy]

I also suggest we enable strict validation here: airflow/www/extensions/init_views.py. It's currently disabled

specification='v1.yaml', base_path='/api/v1', validate_responses=True, strict_validation=False

[mik-laj]

@ephraimbuddy Good point. I will do.

[kaxil]

Wasn't this issue fixed marshmallow-code/marshmallow#377 by marshmallow-code/marshmallow#711 ?

[mik-laj]

@kaxil No. This has only changed in 3.0. We use marshmallow 2.*.
https://marshmallow.readthedocs.io/en/stable/upgrading.html#schemas-are-always-strict
However, we will want to migrate to the new version soon.
dpgaspar/Flask-AppBuilder#1382

[kaxil]

How about using something like since we would always want the strict=True:

class Schema(marshmallow.Schema):
    def __init__(self, strict=True, **kwargs):
        super().__init__(strict=strict, **kwargs)

[mik-laj]

@kaxil This will complicate reviews because we will have to check imports. I do not see the problem that the code is repeated, because it is only one option.

Explicit is better than implicit.

https://www.python.org/dev/peps/pep-0020/

[ephraimbuddy]

Some Schemas uses SQLALchemySchema from marshmallow_sqlalchemy

[kaxil]

@kaxil This will complicate reviews because we will have to check imports. I do not see the problem that the code is repeated, because it is only one option.

Explicit is better than implicit.

https://www.python.org/dev/peps/pep-0020/

We will have to remove all the class that inherits then :D We can call it StrictSchema etc to be explicit.

Then main reason I recommended that was to enforce that we always use strict as it is easy to forget that in new PR and then we end up with some of them strict and some of them not. It is easy then to add pre-commit hook to check that only StrictSchema is used.

Anyways @ephraimbuddy makes a good point that we use SQLALchemySchema at some places. So let's keep it as it is. ✅