-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6399] Serialization: DAG access_control field should be decorated field in DAG serialization #7879
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
…rated field in DAG serialization Co-authored by: Louis Simoneau <simoneau.louis@gmail.com>
c184266
to
b2ab926
Compare
Seems like one of the builds timed out on a CLI test? The tests run green in Breeze on my machine so might just need a bump? |
Yeah. Travis got wuiyr unstable those days. I restarted it. |
Awesome work, congrats on your first merged pull request! |
Thanks @lsimoneau and @codenamelxl |
@kaxil thanks for that. Can I ask if you expect this to be released in a version before 2.0? We rely on serialisation for some of our cluster monitoring, and are trying to roll out RBAC now but this is a blocker. Otherwise we may try building off a fork for now, but wanted to check with you if there were more bugfix releases coming before 2.0. |
Yes this will be included in Airflow 1.10.10 which is expected to be released by early to mid-April (next Month) |
…rated field in DAG serialization (apache#7879) Co-authored by: Louis Simoneau <simoneau.louis@gmail.com> Co-authored-by: Long Le Xich <codenamelxl@users.noreply.github.com> (cherry picked from commit 2d0db94)
This is a modification of #7374 to fix a failing test caused by inconsistent ordering between the serialized DAG and the ground truth DAG.
The
_access_control
field needs to be defined as a decorated field so the field can be serialized/deserialized incorrectly.Issue link: AIRFLOW-6399
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.