Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX add error_cb to confluent.Consumer config in ConsumerFromTopic #44307

Merged
merged 8 commits into from
Dec 8, 2024
Merged

FIX add error_cb to confluent.Consumer config in ConsumerFromTopic #44307

merged 8 commits into from
Dec 8, 2024
+55 −4

Conversation

SuccessMoses
Copy link
Contributor

closes: #43569

@rawwar rawwar self-requested a review November 23, 2024 14:14
rawwar
rawwar reviewed Nov 23, 2024
View reviewed changes
Copy link
Collaborator

@rawwar rawwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, the approach looks good and similar to what I have tested. Please update tests.

@SuccessMoses SuccessMoses requested a review from rawwar December 3, 2024 07:32
potiuk
potiuk approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Good job @SuccessMoses

@potiuk potiuk merged commit 7d05a47 into apache:main Dec 8, 2024
65 checks passed
@SuccessMoses
Copy link
Contributor Author

Thanks for the review

@eladkal eladkal mentioned this pull request Dec 22, 2024
Closed
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
@SuccessMoses
FIX add error_cb to confluent.Consumer config in ConsumerFromTopic (
ec78c13 
apache#44307)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrk-andreev mrk-andreev mrk-andreev left review comments

@potiuk potiuk potiuk approved these changes

@rawwar rawwar Awaiting requested review from rawwar

Assignees
No one assigned
Labels
area:providers provider:apache-kafka
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ConsumeFromTopicOperator does not fail even if wrong credentials are given
4 participants
@SuccessMoses @potiuk @mrk-andreev @rawwar