Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strict_asset_uri_validation #43915

Merged
merged 1 commit into from
Nov 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions airflow/assets/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@

from sqlalchemy.orm.session import Session


from airflow.configuration import conf

__all__ = ["Asset", "AssetAll", "AssetAny", "Dataset"]


Expand Down Expand Up @@ -104,19 +101,7 @@ def _sanitize_uri(uri: str) -> str:
fragment="", # Ignore any fragments.
)
if (normalizer := _get_uri_normalizer(normalized_scheme)) is not None:
try:
parsed = normalizer(parsed)
except ValueError as exception:
if conf.getboolean("core", "strict_asset_uri_validation", fallback=True):
log.error(
(
"The Asset URI %s is not AIP-60 compliant: %s. "
"Please check https://airflow.apache.org/docs/apache-airflow/stable/authoring-and-scheduling/assets.html"
),
uri,
exception,
)
raise
parsed = normalizer(parsed)
return urllib.parse.urlunsplit(parsed)


Expand Down
7 changes: 0 additions & 7 deletions airflow/config_templates/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -482,13 +482,6 @@ core:
sensitive: true
default: ~
example: '{"some_param": "some_value"}'
strict_asset_uri_validation:
description: |
Asset URI validation should raise an exception if it is not compliant with AIP-60.
default: "True"
example: ~
version_added: 2.9.2
type: boolean
database_access_isolation:
description: (experimental) Whether components should use Airflow Internal API for DB connectivity.
version_added: 2.6.0
Expand Down
2 changes: 1 addition & 1 deletion newsfragments/41348.significant.rst
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@

* Rename function ``has_access_dataset`` as ``has_access_asset``

* Rename configuration ``core.strict_dataset_uri_validation`` as ``core.strict_asset_uri_validation``, ``core.dataset_manager_class`` as ``core.asset_manager_class`` and ``core.dataset_manager_class`` as ``core.asset_manager_class``
* Rename configuration ``core.dataset_manager_class`` as ``core.asset_manager_class`` and ``core.dataset_manager_class`` as ``core.asset_manager_class``
* Rename example dags ``example_dataset_alias.py``, ``example_dataset_alias_with_no_taskflow.py``, ``example_datasets.py`` as ``example_asset_alias.py``, ``example_asset_alias_with_no_taskflow.py``, ``example_assets.py``
* Rename DagDependency name ``dataset-alias``, ``dataset`` as ``asset-alias``, ``asset``
* Rename context key ``triggering_dataset_events`` as ``triggering_asset_events``
Expand Down
4 changes: 4 additions & 0 deletions newsfragments/43915.significant.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Configuration ``[core] strict_dataset_uri_validation`` is removed
uranusjr marked this conversation as resolved.
Show resolved Hide resolved

Asset URI with a defined scheme will now always be validated strictly, raising
a hard error on validation failure.