-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DAG.get_num_active_runs #43067
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need this function. There's already an almost-identical function on DagRun that we can use, namely DagRun.active_runs_of_dags. Also simplified that one.
boring-cyborg
bot
added
the
area:Scheduler
including HA (high availability) scheduler
label
Oct 16, 2024
dstandish
requested review from
uranusjr,
ephraimbuddy,
Lee-W and
jedcunningham
October 16, 2024 03:54
potiuk
approved these changes
Oct 16, 2024
shahar1
added
airflow3.0:candidate
Potential candidates for Airflow 3.0
airflow3.0:breaking
Candidates for Airflow 3.0 that contain breaking changes
labels
Oct 16, 2024
shahar1
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it's worth a newfragment as a breaking change, otherwise LGTM
hussein-awala
approved these changes
Oct 16, 2024
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
We don't need this function. There's already an almost-identical function on DagRun that we can use, namely DagRun.active_runs_of_dags. Also simplified that one.
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
We don't need this function. There's already an almost-identical function on DagRun that we can use, namely DagRun.active_runs_of_dags. Also simplified that one.
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
We don't need this function. There's already an almost-identical function on DagRun that we can use, namely DagRun.active_runs_of_dags. Also simplified that one.
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
We don't need this function. There's already an almost-identical function on DagRun that we can use, namely DagRun.active_runs_of_dags. Also simplified that one.
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
airflow3.0:breaking
Candidates for Airflow 3.0 that contain breaking changes
airflow3.0:candidate
Potential candidates for Airflow 3.0
area:Scheduler
including HA (high availability) scheduler
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need this function. There's already an almost-identical function on DagRun that we can use, namely DagRun.active_runs_of_dags.
Also simplified that one.