Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DAG.get_num_active_runs #43067

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

dstandish
Copy link
Contributor

We don't need this function. There's already an almost-identical function on DagRun that we can use, namely DagRun.active_runs_of_dags.

Also simplified that one.

We don't need this function.  There's already an almost-identical function on DagRun that we can use, namely DagRun.active_runs_of_dags.

Also simplified that one.
@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Oct 16, 2024
@shahar1 shahar1 added airflow3.0:candidate Potential candidates for Airflow 3.0 airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes labels Oct 16, 2024
Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it's worth a newfragment as a breaking change, otherwise LGTM

@shahar1 shahar1 added this to the Airflow 3.0.0 milestone Oct 16, 2024
@dstandish dstandish merged commit 598e0ee into apache:main Oct 16, 2024
51 checks passed
@dstandish dstandish deleted the remove-get-num-active-runs branch October 16, 2024 15:07
R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
We don't need this function.  There's already an almost-identical function on DagRun that we can use, namely DagRun.active_runs_of_dags.

Also simplified that one.
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
We don't need this function.  There's already an almost-identical function on DagRun that we can use, namely DagRun.active_runs_of_dags.

Also simplified that one.
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
We don't need this function.  There's already an almost-identical function on DagRun that we can use, namely DagRun.active_runs_of_dags.

Also simplified that one.
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
We don't need this function.  There's already an almost-identical function on DagRun that we can use, namely DagRun.active_runs_of_dags.

Also simplified that one.
@Lee-W Lee-W mentioned this pull request Nov 18, 2024
96 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes airflow3.0:candidate Potential candidates for Airflow 3.0 area:Scheduler including HA (high availability) scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants