Try to make dataset objects totally unhashable #42054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
dataset-unhashable
branch
from
0e3cd50 to
7cac5ae
Compare
We should consider extra...important for tests.
uranusjr
force-pushed
the
dataset-unhashable
branch
from
c71a8f5 to
0695519
Compare
Lee-W
approved these changes
Sep 6, 2024
|
This should generally not affect too many usages, but there’s no harm adding a note I guess. We can’t tell how those are used… |
Lee-W
approved these changes
Sep 6, 2024
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Sep 6, 2024
This reverts commit 1c4a00b.
|
cc: @uranusjr @Lee-W -> we revert it for now as it causes some tests involving open-lineage (in amazon and common.io providers) to fail - see #42059 discussion. Apparently there is an implicit dependency betweeen datasets implementation and amazon/common.io tests Please re-do it and add "full tests needed" label for this change to make sure all the tests are passing. |
potiuk
added a commit
that referenced
this pull request
Sep 6, 2024
|
I think the OpenLineage is not involved here, but the hook level lineage collection is causing different providers to create datasets, so there is a dependency there. |
topherinternational
pushed a commit
to topherinternational/airflow
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the hash property on Dataset (and DatasetAlias) is problematic since subclassing is a possibility, and user code may not correctly implement hashing for Airflow’s purposes.