Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Adding url sanitisation for extra links" #41993

Closed
wants to merge 1 commit into from
Closed

Revert "Adding url sanitisation for extra links" #41993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,6 @@ const ExtraLinks = ({
const isExternal = (url: string | null) =>
url && /^(?:[a-z]+:)?\/\//.test(url);

const isSanitised = (url: string | null) => {
if (!url) {
return true;
}
const urlRegex = /^(https?:)/i;
return urlRegex.test(url);
};

return (
<Box my={3}>
<Text as="strong">Extra Links</Text>
Expand All @@ -71,7 +63,7 @@ const ExtraLinks = ({
as={Link}
colorScheme="blue"
href={url}
isDisabled={!isSanitised(url)}
isDisabled={!url}
target={isExternal(url) ? "_blank" : undefined}
mr={2}
>
Expand Down