Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't Fail LocalTaskJob on heartbeat (#41704) #41810

Merged
merged 1 commit into from
Aug 28, 2024
+8 −3
Merged

Don't Fail LocalTaskJob on heartbeat (#41704) #41810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions airflow/jobs/local_task_job_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,14 @@ def sigusr2_debug_handler(signum, frame):

if span.is_recording():
span.add_event(name="perform_heartbeat")
perform_heartbeat(
job=self.job, heartbeat_callback=self.heartbeat_callback, only_if_necessary=False
)
try:
perform_heartbeat(
job=self.job, heartbeat_callback=self.heartbeat_callback, only_if_necessary=False
)
except Exception as e:
# Failing the heartbeat should never kill the localtaskjob
# If it repeatedly can't heartbeat, it will be marked as a zombie anyhow
self.log.warning("Heartbeat failed with Exception: %s", e)

# If it's been too long since we've heartbeat, then it's possible that
# the scheduler rescheduled this task, so kill launched processes.
Expand Down