Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting syspath preparation into stages #41672

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

amoghrajesh
Copy link
Contributor

Splitting the airflow/settings.py#initialize into stages for easier maintainability.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member

potiuk commented Aug 22, 2024

a test needs fixing

Copy link

@CloudsDocker CloudsDocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this look good to me

@uranusjr
Copy link
Member

Still a test failing

@uranusjr uranusjr merged commit 0be5dec into apache:main Aug 23, 2024
50 checks passed
@potiuk potiuk added this to the Airflow 2.10.1 milestone Aug 23, 2024
@potiuk
Copy link
Member

potiuk commented Aug 23, 2024

This one should also be backported to 2.10.1

uranusjr pushed a commit to astronomer/airflow that referenced this pull request Aug 23, 2024
amoghrajesh added a commit to amoghrajesh/airflow that referenced this pull request Aug 23, 2024
potiuk pushed a commit that referenced this pull request Aug 23, 2024
Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
@utkarsharma2 utkarsharma2 added the type:bug-fix Changelog: Bug Fixes label Aug 30, 2024
utkarsharma2 pushed a commit that referenced this pull request Sep 2, 2024
Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants