Adding url sanitisation for extra links #41665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
Lee-W
reviewed
Aug 22, 2024
Lee-W
approved these changes
Aug 22, 2024
potiuk
approved these changes
Aug 22, 2024
|
Good catch! @amoghrajesh can you cherry pick this for |
|
Oh yeah. My Bad not asking for that. |
|
Marked it as 2.10.1 just in case we miss it accidentally. Also see #41457 (comment) - we should mark all such PRs as |
Ah thanks. Still getting used to this! |
amoghrajesh
added a commit
to amoghrajesh/airflow
that referenced
this pull request
Aug 22, 2024
(cherry picked from commit 6c463b3)
potiuk
pushed a commit
that referenced
this pull request
Aug 22, 2024
utkarsharma2
pushed a commit
that referenced
this pull request
Sep 2, 2024
2 tasks
utkarsharma2
added a commit
that referenced
this pull request
Sep 4, 2024
This reverts commit 6c463b3.
utkarsharma2
added a commit
to astronomer/airflow
that referenced
this pull request
Sep 4, 2024
In the initial PR(apache#41665) we didn't handle the relative path in URL which led to issue(apache#41977). This PR aims at handling the relative path case when sanitizing URLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding url sanitisation for the extra links that can be added and consumed as plugins.
The idea here is to disable the button if there's some violation and the url turns out to be un sanitised.
Before:
After:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.