-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log handler deprecated filename_template argument removal #41552
log handler deprecated filename_template argument removal #41552
Conversation
This PR involves both core and provider changes. The parameter in question is public API which is why we deprecate it first. Now main is Airflow 3 so we can remove it but providers must still be compatible with Airflow 2... so how can we remove it from providers safely now? |
Right now, this field is not being used and has no effect. The filename_template is optional argument with default value None.
As I said in the above statement, the providers can still work with airflow 2. |
@eladkal is right - if someone installs the new provider witn an old configuration in Airlfow 2 with filename_template, it will just fail with "attemptign to iniitalize handlew with "filename_template" argument passed but it's missing" (or smth like that). |
I see the keyword arguments for the all the
Yah. You are right. Most of them are supporting keyword arguments except one/two (like. es handler). |
Just reverting will not be enough, but I think if the base Handler will accept extra arguments (and ignores them) we should be home |
Passing filename_template to a log handler is deprecated and has no effect. So, removing deprecated filename_template argument in log handler.