Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validating provider description for urls in provider list view #40475

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

amoghrajesh
Copy link
Contributor

Validating URLs in Provider Descriptions for Provider List View


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Jun 28, 2024
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. should we add a test to it?

@amoghrajesh
Copy link
Contributor Author

LGTM. should we add a test to it?

Yes it makes sense to add a test for this, @Lee-W can you take a look?

@amoghrajesh amoghrajesh requested review from Lee-W and potiuk June 28, 2024 09:45
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ephraimbuddy ephraimbuddy merged commit f18f484 into apache:main Jun 28, 2024
49 checks passed
@potiuk potiuk added this to the Airflow 2.9.3 milestone Jul 1, 2024
@utkarsharma2 utkarsharma2 added the type:bug-fix Changelog: Bug Fixes label Jul 1, 2024
utkarsharma2 pushed a commit that referenced this pull request Jul 2, 2024
* Validating provider description for urls in provider list view

* adding unit tests

---------

Co-authored-by: adesai <adesai@cloudera.com>
(cherry picked from commit f18f484)
utkarsharma2 pushed a commit that referenced this pull request Jul 2, 2024
* Validating provider description for urls in provider list view

* adding unit tests

---------

Co-authored-by: adesai <adesai@cloudera.com>
(cherry picked from commit f18f484)
utkarsharma2 pushed a commit that referenced this pull request Jul 2, 2024
* Validating provider description for urls in provider list view

* adding unit tests

---------

Co-authored-by: adesai <adesai@cloudera.com>
(cherry picked from commit f18f484)
ephraimbuddy pushed a commit that referenced this pull request Jul 2, 2024
* Validating provider description for urls in provider list view

* adding unit tests

---------

Co-authored-by: adesai <adesai@cloudera.com>
(cherry picked from commit f18f484)
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
…e#40475)

* Validating provider description for urls in provider list view

* adding unit tests

---------

Co-authored-by: adesai <adesai@cloudera.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants