Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KPO Maintain backward compatibility for execute_complete and trigger run method #37454

Merged
merged 1 commit into from
Feb 15, 2024

Commits on Feb 15, 2024

  1. KPO Maintain backward compatibility for execute_complete and trigger …

    …run method
    
    In apache#37279 I introduce periodic logging of the container.
    During the process, I also changed a few event Dict key names
    and that is problematic for someone extending the KPO trigger.
    Also, the current execute_compelete method was unused in the KPO operator
    and was problematic if someone using it in an extended class since
    now the trigger can also emit an event even if the pod is in the pod intermediate state.
    one reported issue: apache#37279 (comment)
    In this PR I'm restoring the trigger event dict structure.
    Also, deprecating the execute_complete method
    pankajastro committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    8fe4702 View commit details
    Browse the repository at this point in the history