KPO Maintain backward compatibility for execute_complete and trigger run method #37363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
pankajkoti
reviewed
Feb 13, 2024
pankajkoti
reviewed
Feb 13, 2024
pankajkoti
reviewed
Feb 13, 2024
pankajkoti
reviewed
Feb 13, 2024
pankajkoti
reviewed
Feb 13, 2024
pankajastro
commented
Feb 14, 2024
pankajkoti
reviewed
Feb 14, 2024
pankajastro
changed the title
pankajastro
changed the title
pankajastro
requested review from
jedcunningham and
hussein-awala
as code owners
This was referenced Feb 14, 2024
|
Hi @pankajastro , I tested the same snippet that I tested here: #37279 (comment) And this time it worked! 🎉 Thank you for the quick fix! |
|
Thank you so much @vchiapaikeo for quickly testing this out |
pankajkoti
approved these changes
Feb 14, 2024
eladkal
approved these changes
Feb 14, 2024
1 task
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Feb 15, 2024
…trigger run method (apache#37363)" This reverts commit 0640e6d.
This was referenced Feb 17, 2024
sunank200
pushed a commit
to astronomer/airflow
that referenced
this pull request
Feb 21, 2024
…run method (apache#37363) * Restore KPO trigger event param name * sync with execute_complete * change trigger emit state done to failed/scuccess * Add deprecation warning * Address review feedback * Fix tests and cleanup * Fix tests * Remove test log stmpt * Fix tests --------- Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
sunank200
pushed a commit
to astronomer/airflow
that referenced
this pull request
Feb 21, 2024
…trigger run method (apache#37363)" (apache#37446) This reverts commit 0640e6d.
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
…run method (apache#37363) * Restore KPO trigger event param name * sync with execute_complete * change trigger emit state done to failed/scuccess * Add deprecation warning * Address review feedback * Fix tests and cleanup * Fix tests * Remove test log stmpt * Fix tests --------- Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
…trigger run method (apache#37363)" (apache#37446) This reverts commit 0640e6d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #37279 I introduce periodic logging of the container.
During the process, I also changed a few event Dict key names
and that is problematic for someone extending the KPO trigger.
Also, the current execute_compelete method was unused in the KPO operator
and was problematic if someone using it in an extended class since
now the trigger can also emit an event even if the pod is in the pod intermediate state.
one reported issue: #37279 (comment)
In this PR I'm restoring the trigger event dict structure.
Also, deprecating the execute_complete method
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.