Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyhive hive_pure_sasl extra name #37323

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

hussein-awala
Copy link
Member

I noticed this warning in the build ci image job:

WARNING: pyhive 0.7.0 does not provide the extra 'hive-pure-sasl'

After checking, found that the correct name of this extra was always hive_pure_sasl: dropbox/PyHive#454

@hussein-awala
Copy link
Member Author

it was added with correct name by #32607

@hussein-awala
Copy link
Member Author

it was changed to the wrong name I think by mistake by #36537

cc: @potiuk

@hussein-awala hussein-awala requested a review from potiuk February 11, 2024 00:15
@potiuk
Copy link
Member

potiuk commented Feb 11, 2024

Not really. That was deliberate and it is there to follow https://peps.python.org/pep-0685/ . Any (conforming) package installer should normalize the extras when comparing them to re.sub(r"[-_.]+", "-", name).lower() - so I pre-normalized all our extras to follow that, so that we are compliant with extras "after normalization".

I believed there is (wrong) warning that the extra does not exist when it is used, but the extra is actually used (or so I thought). But I just checked it and indeed it seems that PEP-0685 for that case is not yet implemented by pip. @uranusjr ?

@potiuk potiuk added this to the Airflow 2.8.2 milestone Feb 11, 2024
@potiuk potiuk merged commit 9a10085 into apache:main Feb 11, 2024
81 checks passed
@potiuk
Copy link
Member

potiuk commented Feb 11, 2024

Yeah, this is simply manifestation of unfinished pypa/pip#11445

@potiuk potiuk added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) and removed kind:documentation labels Feb 12, 2024
potiuk pushed a commit that referenced this pull request Feb 13, 2024
ephraimbuddy pushed a commit that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:apache-hive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants