-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pyhive hive_pure_sasl extra name #37323
Conversation
it was added with correct name by #32607 |
Not really. That was deliberate and it is there to follow https://peps.python.org/pep-0685/ . Any (conforming) package installer should normalize the extras when comparing them to I believed there is (wrong) warning that the extra does not exist when it is used, but the extra is actually used (or so I thought). But I just checked it and indeed it seems that PEP-0685 for that case is not yet implemented by |
Yeah, this is simply manifestation of unfinished pypa/pip#11445 |
(cherry picked from commit 9a10085)
(cherry picked from commit 9a10085)
I noticed this warning in the build ci image job:
After checking, found that the correct name of this extra was always
hive_pure_sasl
: dropbox/PyHive#454