fix: PythonVirtualenvOperator crashes if any python_callable function is defined in the same source as DAG #37165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kalyanr <kalyan.ben10@live.com>
boring-cyborg
bot
added
the
area:core-operators
rawwar
commented
Feb 4, 2024
rawwar
commented
Feb 4, 2024
Signed-off-by: kalyanr <kalyan.ben10@live.com>
rawwar
commented
Feb 4, 2024
This reverts commit f8a1ea9. Signed-off-by: kalyanr <kalyan.ben10@live.com>
2 tasks
|
No specific comments for now, this is the direction that I think makes sense. |
Signed-off-by: kalyanr <kalyan.ben10@live.com>
|
@potiuk , Please consider reviewing the PR. Thanks |
potiuk
approved these changes
Feb 7, 2024
|
Nice |
68 tasks
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
… is defined in the same source as DAG (apache#37165) --------- Signed-off-by: kalyanr <kalyan.ben10@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #35529
Added a check to see if the
python_callable's module name is same as the modified unique path. This helps us to identify that the python callable is in the same module as the dag.