Add get_permitted_menu_items
in auth manager
#36871
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the menu in Airflow UI is using the filter is_menu_visible to display or not each menu item. Each call to
is_menu_visible
calls has_access which then call anis_authorized_
method from the auth manager used in the environment. Most likely, all auth managers (with the exception of fab) will call an external service for everyis_authorized_
method. Today, displaying the menu call 26 times anis_authorized_
method which can be very expensive and make the Airflow UI slower.Introducing
get_permitted_menu_items
which is responsible of returning the menu given user permissions can replace these 26 calls to one (if the service used by the auth manager is capable of multiple authz requests in one API).^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.