Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check sagemaker training job status before deferring SageMakerTrainingOperator #36685

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Jan 9, 2024

While running a sagemaker training job in deferrable mode, the condition might already be met before we defer the task into the trigger. This PR intends to check the job status before deferring the task to trigger.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon-aws AWS/Amazon - related issues labels Jan 9, 2024
@Lee-W Lee-W force-pushed the check-sagemaker-training-job-status-before-deferring branch 2 times, most recently from e7d9b8d to 97e7d92 Compare January 15, 2024 10:48
@Lee-W Lee-W marked this pull request as ready for review January 15, 2024 10:51
@Lee-W Lee-W force-pushed the check-sagemaker-training-job-status-before-deferring branch 3 times, most recently from 1ed4567 to d1aabc5 Compare January 17, 2024 09:22
@Lee-W Lee-W force-pushed the check-sagemaker-training-job-status-before-deferring branch from d1aabc5 to 8914b72 Compare January 19, 2024 00:12
@Lee-W Lee-W force-pushed the check-sagemaker-training-job-status-before-deferring branch from 8914b72 to 3828cde Compare January 30, 2024 09:45
@Lee-W Lee-W force-pushed the check-sagemaker-training-job-status-before-deferring branch 10 times, most recently from 74b8713 to 2d13124 Compare February 1, 2024 03:44
@Lee-W Lee-W force-pushed the check-sagemaker-training-job-status-before-deferring branch 3 times, most recently from 7471a1a to 026f528 Compare February 1, 2024 04:26
Copy link
Member

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a static check is failing

@Lee-W Lee-W force-pushed the check-sagemaker-training-job-status-before-deferring branch 2 times, most recently from d29d34b to 358a20f Compare February 1, 2024 13:27
@Lee-W Lee-W force-pushed the check-sagemaker-training-job-status-before-deferring branch from 358a20f to 9cae465 Compare February 3, 2024 13:05
@phanikumv phanikumv merged commit 2e95a2a into apache:main Feb 5, 2024
57 checks passed
@phanikumv phanikumv deleted the check-sagemaker-training-job-status-before-deferring branch February 5, 2024 02:21
abhishekbhakat pushed a commit to abhishekbhakat/my_airflow that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants