Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jsonschema version to 4.18.0 #32445

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Conversation

hussein-awala
Copy link
Member

related: #32434

Bump the min jsonschema version to 4.18.0 to improve its performance (more details)


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@eladkal eladkal added this to the Airflow 2.6.4 milestone Jul 8, 2023
@hussein-awala
Copy link
Member Author

python-openapi/openapi-schema-validator@5bf8b10

I will try to bump openapi-schema-validator version in amazon provider

@hussein-awala
Copy link
Member Author

and there is a core test which fail with python 3.11:

FAILED tests/models/test_param.py::TestParam::test_string_date_format[20120503] - airflow.exceptions.ParamValidationError: '20120503' is not a 'date'

Failed validating 'format' in schema:
    {'format': 'date', 'type': 'string'}

On instance:
    '20120503'

@tirkarthi
Copy link
Contributor

python-jsonschema/jsonschema#1056

@hussein-awala hussein-awala requested a review from o-nikolas as a code owner July 9, 2023 09:47

from airflow.providers.amazon.aws.hooks.cloud_formation import CloudFormationHook

# TODO: restore this test with moto when openapi_schema_validator 0.6.0 is released
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is using pytest.mark.skip a better option here?

@potiuk
Copy link
Member

potiuk commented Jul 9, 2023

needs tests fixing :(

Signed-off-by: Hussein Awala <hussein@awala.fr>
Signed-off-by: Hussein Awala <hussein@awala.fr>
@potiuk potiuk force-pushed the bump_jsonschema branch from b3edcd2 to d05a4af Compare July 10, 2023 13:00
@potiuk
Copy link
Member

potiuk commented Jul 10, 2023

Merging. 3.11 and other tests passed with it, and main is already broken so better to merge it fast to fix it.

@potiuk potiuk merged commit 48edb2b into apache:main Jul 10, 2023
@eladkal eladkal modified the milestones: Airflow 2.6.4, Airflow 2.7.0 Aug 1, 2023
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants