-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump jsonschema version to 4.18.0 #32445
Conversation
python-openapi/openapi-schema-validator@5bf8b10 I will try to bump |
and there is a core test which fail with python 3.11:
|
|
||
from airflow.providers.amazon.aws.hooks.cloud_formation import CloudFormationHook | ||
|
||
# TODO: restore this test with moto when openapi_schema_validator 0.6.0 is released |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is using pytest.mark.skip a better option here?
needs tests fixing :( |
Signed-off-by: Hussein Awala <hussein@awala.fr>
Signed-off-by: Hussein Awala <hussein@awala.fr>
Merging. 3.11 and other tests passed with it, and main is already broken so better to merge it fast to fix it. |
related: #32434
Bump the min jsonschema version to 4.18.0 to improve its performance (more details)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.