Fix min_backoff calculation in base sensor when exponential_backoff is on #31412
+37
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:core-operators
| @@ -265,7 +265,8 @@ def _get_next_poke_interval( | |||
| if not self.exponential_backoff: | |||
| return self.poke_interval | |||
|
|
|||
| min_backoff = int(self.poke_interval * (2 ** (try_number - 2))) | |||
| # The value of min_backoff should always be greater than or equal to 1. | |||
| min_backoff = max(int(self.poke_interval * (2 ** (try_number - 2))), 1) | |||
There was a problem hiding this comment.
I wonder if we can be able to add test for this?
There was a problem hiding this comment.
can you check the test which I just added?
ephraimbuddy
approved these changes
May 23, 2023
eladkal
pushed a commit
that referenced
this pull request
Jun 8, 2023
(cherry picked from commit a98621f)
eladkal
pushed a commit
that referenced
this pull request
Jun 9, 2023
(cherry picked from commit a98621f)
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #31409
Make sensor poking exponential backoff consistent with TI retrying exponential backoff:
airflow/airflow/models/taskinstance.py
Lines 1172 to 1179 in 7bf952b
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.