Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always pass named type_ arg to drop_constraint #31306

Merged
merged 1 commit into from
May 16, 2023
Merged

Always pass named type_ arg to drop_constraint #31306

merged 1 commit into from
May 16, 2023

Conversation

uranusjr
Copy link
Member

It seems Alembic recently starts to enforce this argument being passed using a keyword (instead of positional). These are failing since the upstream change.

@uranusjr
Always pass named type_ arg to drop_constraint
2cb3d2a 
It seems Alembic recently starts to enforce this argument being passed
using a keyword (instead of positional). These are failing since the
upstream change.
@uranusjr uranusjr requested a review from potiuk as a code owner May 16, 2023 03:40
@uranusjr uranusjr mentioned this pull request May 16, 2023
Merged
@dstandish dstandish merged commit 4dacab3 into apache:main May 16, 2023
@dstandish dstandish deleted the drop-constraints-type branch May 16, 2023 05:24
@potiuk potiuk mentioned this pull request May 16, 2023
Merged
potiuk added a commit to potiuk/airflow that referenced this pull request May 16, 2023
@potiuk
Use keyword paramaters for migration methods for mssql
ea1220d 
The new alembic (1.11.0) requires parameters to be keyword
parameters in methods used in migrations. Part of the problem has
been fixed in apache#31306 and apache#31302 but still some migrations that are
specifically run in case of mssql need to use migration parameters.
potiuk added a commit that referenced this pull request May 16, 2023
@potiuk
Use keyword paramaters for migration methods for mssql (#31309)
5479027 
The new alembic (1.11.0) requires parameters to be keyword
parameters in methods used in migrations. Part of the problem has
been fixed in #31306 and #31302 but still some migrations that are
specifically run in case of mssql need to use migration parameters.
@potiuk potiuk mentioned this pull request May 16, 2023
Closed
2 tasks
@potiuk potiuk added this to the Airflow 2.6.2 milestone May 16, 2023
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Jun 8, 2023
eladkal pushed a commit that referenced this pull request Jun 8, 2023
@potiuk
Use keyword paramaters for migration methods for mssql (#31309)
12f17cc 
The new alembic (1.11.0) requires parameters to be keyword
parameters in methods used in migrations. Part of the problem has
been fixed in #31306 and #31302 but still some migrations that are
specifically run in case of mssql need to use migration parameters.

(cherry picked from commit 5479027)
potiuk added a commit that referenced this pull request Jun 9, 2023
@potiuk
Use keyword paramaters for migration methods for mssql (#31309)
ea8c0a1 
The new alembic (1.11.0) requires parameters to be keyword
parameters in methods used in migrations. Part of the problem has
been fixed in #31306 and #31302 but still some migrations that are
specifically run in case of mssql need to use migration parameters.

(cherry picked from commit 5479027)
@eladkal eladkal mentioned this pull request Jun 13, 2023
Closed
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstandish dstandish dstandish approved these changes

@eladkal eladkal eladkal approved these changes

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

Assignees
No one assigned
Labels
kind:documentation type:bug-fix Changelog: Bug Fixes
Projects
None yet
Milestone
Airflow 2.6.2
Development

Successfully merging this pull request may close these issues.
4 participants
@uranusjr @dstandish @eladkal @potiuk