Add future-compatible mongo Hook typing #31289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
approved these changes
May 15, 2023
potiuk
force-pushed
the
add-future-compatible-typing-for-mongo
branch
from
3b905f4
to
01e2d0a
Compare
|
Looks like two more changes needed in |
potiuk
force-pushed
the
add-future-compatible-typing-for-mongo
branch
from
01e2d0a
to
155d6ff
Compare
josh-fell
reviewed
May 15, 2023
We are migrating to new mongo library soon and it has typing support. This one adds propert typing that will prevent MyPy from failing once mongo gets upgraded.
potiuk
force-pushed
the
add-future-compatible-typing-for-mongo
branch
from
155d6ff
to
1c02363
Compare
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are migrating to new mongo library soon and it has typing support. This one adds propert typing that will prevent MyPy from failing once mongo gets upgraded.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.