GKEPodHook needs to have all methods KPO calls #31266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From time to time methods are added to KubernetesHook for use with KPO and we neglect to add them to GKEPodHook, thus breaking GKEStartPodOperator. Here I add missing methods and a test to ensure that the two classes stay consistent in the ways necessary. It might be nice to make a common interface such as KubernetesPodOperatorHookInterface which would define the necessary methods, but that is deferred for another day. For now we simply update GKEPodHook and at an easy test to verify consistency.
boring-cyborg
bot
added
provider:cncf-kubernetes
|
@shahar1 you might be interested |
dstandish
commented
May 12, 2023
| @staticmethod | ||
| def get_xcom_sidecar_container_image(): | ||
| """Returns the xcom sidecar image that defined in the connection""" | ||
| return PodDefaults.SIDECAR_CONTAINER.image |
There was a problem hiding this comment.
we don't need this because returning None gets you to the same place. (and we shouldn't be using pod_generator_deprecated anyway)
shahar1
approved these changes
May 12, 2023
eladkal
approved these changes
May 12, 2023
hussein-awala
approved these changes
May 14, 2023
This was referenced May 15, 2023
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From time to time methods are added to KubernetesHook for use with KPO and we neglect to add them to GKEPodHook, thus breaking GKEStartPodOperator. Here I add missing methods and a test to ensure that the two classes stay consistent in the ways necessary.
It might be nice to make a common interface such as KubernetesPodOperatorHookInterface which would define the necessary methods, but that is deferred for another day. For now we simply update GKEPodHook and at an easy test to verify consistency.