Add retries to S3 delete_bucket #31192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon-aws
vandonr-amz
approved these changes
May 10, 2023
|
I wish we didn't have to do this... |
o-nikolas
approved these changes
May 10, 2023
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
delete_bucketrequires that the bucket is empty before it can be deleted but does not provide a convenientempty_bucketmethod. We have found that on some edge cases, an API call might write logs or artifacts to the S3 bucket with a delay, which causes the delete_bucket task to fail if the object was added while we were iterating the list of objects. This PR attempts to ensure all objects are actually deleted by retrying (up to N times) until no objects remain before trying to delete the bucket.@o-nikolas , @vincbeck , @vandonr-amz - This is the PR we discussed yesterday.