Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate connection IDs #31140

Merged
merged 3 commits into from
May 12, 2023
Merged

Conversation

mattusifer
Copy link
Contributor

@mattusifer mattusifer commented May 9, 2023

Apply the existing validate_key function to Connection IDs in order to restrict allowed characters.

Fixes #29836


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label May 9, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented May 9, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@mattusifer mattusifer force-pushed the musifer/validate-connection-id branch from 71a5e49 to 3646ff5 Compare May 9, 2023 02:58
airflow/www/validators.py Outdated Show resolved Hide resolved
@mattusifer mattusifer marked this pull request as ready for review May 9, 2023 11:41
airflow/www/validators.py Outdated Show resolved Hide resolved
@uranusjr
Copy link
Member

Also need to fix static checks. Otherwise looks good to me.

@mattusifer mattusifer force-pushed the musifer/validate-connection-id branch from 972e518 to 1c5411e Compare May 10, 2023 14:19
@mattusifer
Copy link
Contributor Author

Thank you @uranusjr ! Resolved those issues, let me know if there is anything else.

@eladkal eladkal added the type:improvement Changelog: Improvements label May 12, 2023
@eladkal eladkal added this to the Airflow 2.6.2 milestone May 12, 2023
@eladkal eladkal merged commit 5cb8ef8 into apache:main May 12, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented May 12, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@mattusifer mattusifer deleted the musifer/validate-connection-id branch May 12, 2023 11:45
eladkal pushed a commit that referenced this pull request Jun 8, 2023
* Validate connection_ids

(cherry picked from commit 5cb8ef8)
@eladkal eladkal added type:misc/internal Changelog: Misc changes that should appear in change log type:bug-fix Changelog: Bug Fixes and removed type:improvement Changelog: Improvements type:misc/internal Changelog: Misc changes that should appear in change log labels Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restrict allowed characters in connection ids
3 participants