Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement gcs_schema_object for BigQueryCreateExternalTableOperator #30961

Conversation

attilaszombati
Copy link
Contributor

@attilaszombati attilaszombati commented Apr 29, 2023

Before this PR:

The BigQueryCreateExternalTableOperator can work with the schema object if the JSON file is in the same bucket as the data source objects.

After this PR:

The developers have the ability to define a different bucket where the schema object is located like the implementation of the BigQueryCreateEmptyTableOperator.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Apr 29, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 29, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@pankajastro
Copy link
Member

shall we add a test for it or update some existing tests?

@attilaszombati
Copy link
Contributor Author

@pankajastro good point, I will add some tests to cover this parameter

@attilaszombati
Copy link
Contributor Author

@pankajastro I found one test for this operator, doesn't seem a good idea to create a new test case just for this parameter. If you think it's necessary then I can create a separate one.

For now, I just added the new parameter to the test as well. What do you think?

@potiuk potiuk force-pushed the bigquery-external-table-schema-object-from-different-bucket branch from 76f9ab0 to 104331b Compare May 8, 2023 19:49
@potiuk potiuk merged commit e68d4a7 into apache:main May 8, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented May 8, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants