-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement gcs_schema_object for BigQueryCreateExternalTableOperator #30961
implement gcs_schema_object for BigQueryCreateExternalTableOperator #30961
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
shall we add a test for it or update some existing tests? |
@pankajastro good point, I will add some tests to cover this parameter |
@pankajastro I found one test for this operator, doesn't seem a good idea to create a new test case just for this parameter. If you think it's necessary then I can create a separate one. For now, I just added the new parameter to the test as well. What do you think? |
76f9ab0
to
104331b
Compare
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Before this PR:
The BigQueryCreateExternalTableOperator can work with the schema object if the JSON file is in the same bucket as the data source objects.
After this PR:
The developers have the ability to define a different bucket where the schema object is located like the implementation of the BigQueryCreateEmptyTableOperator.