Fixing various issues in utils folder reported by MyPy #20504
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19891
Fixes number of issues reported by MyPy:
dates
variablestates_by_task_id
is not Optional as functions upstream and downstream are not that passes the same variablerender_dag_dependencies
function's only parameter is not optional as it does not handle that case nor anywhere in the codebase it is accessed as emptyself.filename_template
andself.filename_jinja_template
are Optional and hence need to be handled accordingly inside_render_filename
functionlocalize
andconvert
methodsrelativedelta
does not define type forseconds
and accepts float (I tested empirically) as well which MyPy complains that is not allowed. So, ignoringv
inpendulum.instance(v
can not be None as previous check and hence failingThis is Part 1 for (airflow/utils) and will do Part 2 in a separate PR to keep scope small for review and focus.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.