-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename DAG concurrency settings for easier understanding #16267
Conversation
1794c4e
to
80ee573
Compare
740c91c
to
516539c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate how I very clearly know what this means by just reading the name.
516539c
to
cc2f6a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes a lot of sense now! Thanks Kaxil!
Just some REST API test fix. LGTM
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
``dag_conccurency`` -> ``max_active_tasks_per_dag``
Follow-up of apache#16267 Renames `task_concurrency` to `max_active_tis_per_dag` Some of Airflow's concurrency settings have been a source of confusion for a lot of users (including me), for example: https://stackoverflow.com/questions/56370720/how-to-control-the-parallelism-or-concurrency-of-an-airflow-installation https://stackoverflow.com/questions/38200666/airflow-parallelism This PR is an attempt to make the settings easier to understand
Follow-up of #16267 Renames `task_concurrency` to `max_active_tis_per_dag` Some of Airflow's concurrency settings have been a source of confusion for a lot of users (including me), for example: https://stackoverflow.com/questions/56370720/how-to-control-the-parallelism-or-concurrency-of-an-airflow-installation https://stackoverflow.com/questions/38200666/airflow-parallelism This PR is an attempt to make the settings easier to understand
Follow-up of apache/airflow#16267 . Docstrings should show new values instead of deprecated. (`max_active_tasks` instead of concurency) GitOrigin-RevId: 3b41bb45e6e25c1482847e30793c2413b386589b
Follow-up of apache/airflow#16267 Renames `task_concurrency` to `max_active_tis_per_dag` Some of Airflow's concurrency settings have been a source of confusion for a lot of users (including me), for example: https://stackoverflow.com/questions/56370720/how-to-control-the-parallelism-or-concurrency-of-an-airflow-installation https://stackoverflow.com/questions/38200666/airflow-parallelism This PR is an attempt to make the settings easier to understand GitOrigin-RevId: 35a6c302772bf5d0bb74646b2da04856c7d7aaac
Follow-up of apache/airflow#16267 . Docstrings should show new values instead of deprecated. (`max_active_tasks` instead of concurency) GitOrigin-RevId: 3b41bb45e6e25c1482847e30793c2413b386589b
Follow-up of apache/airflow#16267 Renames `task_concurrency` to `max_active_tis_per_dag` Some of Airflow's concurrency settings have been a source of confusion for a lot of users (including me), for example: https://stackoverflow.com/questions/56370720/how-to-control-the-parallelism-or-concurrency-of-an-airflow-installation https://stackoverflow.com/questions/38200666/airflow-parallelism This PR is an attempt to make the settings easier to understand GitOrigin-RevId: 35a6c302772bf5d0bb74646b2da04856c7d7aaac
Follow-up of apache/airflow#16267 . Docstrings should show new values instead of deprecated. (`max_active_tasks` instead of concurency) GitOrigin-RevId: 3b41bb45e6e25c1482847e30793c2413b386589b
Follow-up of apache/airflow#16267 Renames `task_concurrency` to `max_active_tis_per_dag` Some of Airflow's concurrency settings have been a source of confusion for a lot of users (including me), for example: https://stackoverflow.com/questions/56370720/how-to-control-the-parallelism-or-concurrency-of-an-airflow-installation https://stackoverflow.com/questions/38200666/airflow-parallelism This PR is an attempt to make the settings easier to understand GitOrigin-RevId: 35a6c302772bf5d0bb74646b2da04856c7d7aaac
Very clear name |
Your praised very simple It's all perfectly logical and accurate. As opposed to previous name which was wrong and illogical. |
Jarec thank you very much for clarification. Now I see why that changed! To be more clear I'm looking not from an Airflow developer perspective but from an Airflow user perspective, so I don't know how it's named in the code. I just updated my Airflow instance and started to see a deprecation warnings about this "tis" 😄 I'm not trying to dispute that name, just telling about my experience. |
And I am just answering your question - very precisely and accurately - "How did it happen?". |
Thank you for that! |
Follow-up of apache/airflow#16267 . Docstrings should show new values instead of deprecated. (`max_active_tasks` instead of concurency) GitOrigin-RevId: 3b41bb45e6e25c1482847e30793c2413b386589b
Follow-up of apache/airflow#16267 Renames `task_concurrency` to `max_active_tis_per_dag` Some of Airflow's concurrency settings have been a source of confusion for a lot of users (including me), for example: https://stackoverflow.com/questions/56370720/how-to-control-the-parallelism-or-concurrency-of-an-airflow-installation https://stackoverflow.com/questions/38200666/airflow-parallelism This PR is an attempt to make the settings easier to understand GitOrigin-RevId: 35a6c302772bf5d0bb74646b2da04856c7d7aaac
Follow-up of apache/airflow#16267 . Docstrings should show new values instead of deprecated. (`max_active_tasks` instead of concurency) GitOrigin-RevId: 3b41bb45e6e25c1482847e30793c2413b386589b
Follow-up of apache/airflow#16267 Renames `task_concurrency` to `max_active_tis_per_dag` Some of Airflow's concurrency settings have been a source of confusion for a lot of users (including me), for example: https://stackoverflow.com/questions/56370720/how-to-control-the-parallelism-or-concurrency-of-an-airflow-installation https://stackoverflow.com/questions/38200666/airflow-parallelism This PR is an attempt to make the settings easier to understand GitOrigin-RevId: 35a6c302772bf5d0bb74646b2da04856c7d7aaac
Follow-up of apache/airflow#16267 . Docstrings should show new values instead of deprecated. (`max_active_tasks` instead of concurency) GitOrigin-RevId: 3b41bb45e6e25c1482847e30793c2413b386589b
Follow-up of apache/airflow#16267 Renames `task_concurrency` to `max_active_tis_per_dag` Some of Airflow's concurrency settings have been a source of confusion for a lot of users (including me), for example: https://stackoverflow.com/questions/56370720/how-to-control-the-parallelism-or-concurrency-of-an-airflow-installation https://stackoverflow.com/questions/38200666/airflow-parallelism This PR is an attempt to make the settings easier to understand GitOrigin-RevId: 35a6c302772bf5d0bb74646b2da04856c7d7aaac
Follow-up of apache/airflow#16267 . Docstrings should show new values instead of deprecated. (`max_active_tasks` instead of concurency) GitOrigin-RevId: 3b41bb45e6e25c1482847e30793c2413b386589b
Follow-up of apache/airflow#16267 Renames `task_concurrency` to `max_active_tis_per_dag` Some of Airflow's concurrency settings have been a source of confusion for a lot of users (including me), for example: https://stackoverflow.com/questions/56370720/how-to-control-the-parallelism-or-concurrency-of-an-airflow-installation https://stackoverflow.com/questions/38200666/airflow-parallelism This PR is an attempt to make the settings easier to understand GitOrigin-RevId: 35a6c302772bf5d0bb74646b2da04856c7d7aaac
Follow-up of apache/airflow#16267 . Docstrings should show new values instead of deprecated. (`max_active_tasks` instead of concurency) GitOrigin-RevId: 3b41bb45e6e25c1482847e30793c2413b386589b
Follow-up of apache/airflow#16267 Renames `task_concurrency` to `max_active_tis_per_dag` Some of Airflow's concurrency settings have been a source of confusion for a lot of users (including me), for example: https://stackoverflow.com/questions/56370720/how-to-control-the-parallelism-or-concurrency-of-an-airflow-installation https://stackoverflow.com/questions/38200666/airflow-parallelism This PR is an attempt to make the settings easier to understand GitOrigin-RevId: 35a6c302772bf5d0bb74646b2da04856c7d7aaac
Follow-up of apache/airflow#16267 . Docstrings should show new values instead of deprecated. (`max_active_tasks` instead of concurency) GitOrigin-RevId: 3b41bb45e6e25c1482847e30793c2413b386589b
Follow-up of apache/airflow#16267 Renames `task_concurrency` to `max_active_tis_per_dag` Some of Airflow's concurrency settings have been a source of confusion for a lot of users (including me), for example: https://stackoverflow.com/questions/56370720/how-to-control-the-parallelism-or-concurrency-of-an-airflow-installation https://stackoverflow.com/questions/38200666/airflow-parallelism This PR is an attempt to make the settings easier to understand GitOrigin-RevId: 35a6c302772bf5d0bb74646b2da04856c7d7aaac
Follow-up of apache/airflow#16267 . Docstrings should show new values instead of deprecated. (`max_active_tasks` instead of concurency) GitOrigin-RevId: 3b41bb45e6e25c1482847e30793c2413b386589b
Follow-up of apache/airflow#16267 Renames `task_concurrency` to `max_active_tis_per_dag` Some of Airflow's concurrency settings have been a source of confusion for a lot of users (including me), for example: https://stackoverflow.com/questions/56370720/how-to-control-the-parallelism-or-concurrency-of-an-airflow-installation https://stackoverflow.com/questions/38200666/airflow-parallelism This PR is an attempt to make the settings easier to understand GitOrigin-RevId: 35a6c302772bf5d0bb74646b2da04856c7d7aaac
Follow-up of apache/airflow#16267 . Docstrings should show new values instead of deprecated. (`max_active_tasks` instead of concurency) GitOrigin-RevId: 3b41bb45e6e25c1482847e30793c2413b386589b
Follow-up of apache/airflow#16267 Renames `task_concurrency` to `max_active_tis_per_dag` Some of Airflow's concurrency settings have been a source of confusion for a lot of users (including me), for example: https://stackoverflow.com/questions/56370720/how-to-control-the-parallelism-or-concurrency-of-an-airflow-installation https://stackoverflow.com/questions/38200666/airflow-parallelism This PR is an attempt to make the settings easier to understand GitOrigin-RevId: 35a6c302772bf5d0bb74646b2da04856c7d7aaac
dag_concurrency
->max_active_tasks_per_dag
ToDo:
max_active_tasks_per_dag
: "To stop a new dag with an early start date from stealing all the executor slots in a cluster?"DAG.concurrency
BaseOperator.task_concurrency
settings too. (Will do this as a separate PR as the change is becoming quite BIG)Some of Airflow's concurrency settings have been a source of confusion for a lot of users (including me), for example:
This PR is an attempt to make the settings easier to understand
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.