-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI check for scheduler(s) #14519
Conversation
airflow/cli/cli_parser.py
Outdated
return True | ||
if value > 0: | ||
return value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The return value is either bool or an int - is this inconsistency expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Thanks
@@ -20,6 +20,11 @@ | |||
Checking Airflow Health Status | |||
============================== | |||
|
|||
Airflow has two methods to check the health of components. Their choice depends on the role of the component as well as what tools it uses to monitor the application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the second method? This section (as defined by ====) mentions only API endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Thanks
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
Co-authored-by: Kamil Breguła <kamilbregula@apache.org> (cherry picked from commit f25ec33)
Part of: #11161
I miss a simple method to check if the scheduler is in good health, so I added a command that allows me to do it. Additionally, I updated
docker-compose.yaml
to take use itFor now, we've been doing without this command because we had a Python script implemented that did similar behavior, but that doesn't look right.
airflow/chart/templates/scheduler/scheduler-deployment.yaml
Lines 126 to 143 in 7d18150
I am not updating the Helm Chart yet to keep compatibilityy with Airflow 1.10, but when we drop support for Aiirflow 1.10, we will be able to use it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.