Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from helm-unittest to python unittest #11827

Merged
merged 3 commits into from
Oct 30, 2020
Merged

Migrate from helm-unittest to python unittest #11827

merged 3 commits into from
Oct 30, 2020

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Oct 24, 2020 •
edited
Loading

I am waiting for the @dimberman 's change to be merged, but in the meantime I have converted all tests with an automated script.

Part of: #11657
Depends on: #11693

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@mik-laj mik-laj force-pushed the migrate-to-unittest branch from 34b22c4 to 5a2ae50 Compare October 25, 2020 06:32
@github-actions
Copy link

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

This was referenced Oct 26, 2020
Merged
Open
@mik-laj mik-laj force-pushed the migrate-to-unittest branch from 5346a2f to fae77aa Compare October 28, 2020 01:42
@github-actions
Copy link

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

@mik-laj mik-laj force-pushed the migrate-to-unittest branch from fae77aa to 70973e6 Compare October 28, 2020 02:00
@mik-laj mik-laj closed this Oct 28, 2020
@mik-laj mik-laj reopened this Oct 28, 2020
@mik-laj mik-laj mentioned this pull request Oct 28, 2020
Closed
@mik-laj
Copy link
Member Author

mik-laj commented Oct 28, 2020

@OmairK Can you look at it?

@OmairK
Copy link
Contributor

OmairK commented Oct 28, 2020

@OmairK Can you look at it?

Thanks @mik-laj I will have a look at it.

@mik-laj
Copy link
Member Author

mik-laj commented Oct 28, 2020

The automatic converter is available here: https://gist.github.com/mik-laj/3ae253d5394b34447dcbd426fd19b389

@mik-laj mik-laj marked this pull request as ready for review October 28, 2020 13:52
@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@mik-laj mik-laj requested review from potiuk and dimberman October 29, 2020 14:06
@mik-laj mik-laj force-pushed the migrate-to-unittest branch from 7411e0b to 2d4c7e5 Compare October 29, 2020 14:54
@mik-laj mik-laj requested a review from turbaszek October 30, 2020 14:34
dimberman
dimberman approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@dimberman dimberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh damn, you beat me to it :)

@dimberman dimberman merged commit 9322f3e into apache:master Oct 30, 2020
potiuk added a commit to PolideaInternal/airflow that referenced this pull request Oct 30, 2020
@potiuk
Fixes broken ci.yaml workflow
634239b 
The PR apache#11827 broke the ci.yaml workflow by not removing helm-test
reference in tag-repo-nightly. This PR fixes it.
@potiuk potiuk mentioned this pull request Oct 30, 2020
Merged
dimberman pushed a commit that referenced this pull request Oct 30, 2020
@potiuk
Fixes broken ci.yaml workflow (#11981)
69c00d9 
The PR #11827 broke the ci.yaml workflow by not removing helm-test
reference in tag-repo-nightly. This PR fixes it.
szn pushed a commit to szn/airflow that referenced this pull request Nov 1, 2020
@mik-laj
Migrate from helm-unittest to python unittest (apache#11827)
a8dbe9d 
* Migrate from helm-unittest to python unittest

* fixup! Migrate from helm-unittest to python unittest

* fixup! fixup! Migrate from helm-unittest to python unittest
szn pushed a commit to szn/airflow that referenced this pull request Nov 1, 2020
@potiuk
Fixes broken ci.yaml workflow (apache#11981)
78c4a2c 
The PR apache#11827 broke the ci.yaml workflow by not removing helm-test
reference in tag-repo-nightly. This PR fixes it.
potiuk pushed a commit that referenced this pull request Nov 14, 2020
@mik-laj @potiuk
Migrate from helm-unittest to python unittest (#11827)
572387d 
* Migrate from helm-unittest to python unittest

* fixup! Migrate from helm-unittest to python unittest

* fixup! fixup! Migrate from helm-unittest to python unittest

(cherry picked from commit 9322f3e)
@potiuk potiuk added the type:misc/internal Changelog: Misc changes that should appear in change log label Nov 14, 2020
@potiuk potiuk added this to the Airflow 1.10.13 milestone Nov 14, 2020
potiuk pushed a commit that referenced this pull request Nov 16, 2020
@mik-laj @potiuk
Migrate from helm-unittest to python unittest (#11827)
1677ed8 
* Migrate from helm-unittest to python unittest

* fixup! Migrate from helm-unittest to python unittest

* fixup! fixup! Migrate from helm-unittest to python unittest

(cherry picked from commit 9322f3e)
potiuk pushed a commit that referenced this pull request Nov 16, 2020
@mik-laj @potiuk
Migrate from helm-unittest to python unittest (#11827)
5d16302 
* Migrate from helm-unittest to python unittest

* fixup! Migrate from helm-unittest to python unittest

* fixup! fixup! Migrate from helm-unittest to python unittest

(cherry picked from commit 9322f3e)
kaxil pushed a commit that referenced this pull request Nov 18, 2020
@mik-laj @kaxil
Migrate from helm-unittest to python unittest (#11827)
39e3912 
* Migrate from helm-unittest to python unittest

* fixup! Migrate from helm-unittest to python unittest

* fixup! fixup! Migrate from helm-unittest to python unittest

(cherry picked from commit 9322f3e)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
@mik-laj
Migrate from helm-unittest to python unittest (apache#11827)
f27c55d 
* Migrate from helm-unittest to python unittest

* fixup! Migrate from helm-unittest to python unittest

* fixup! fixup! Migrate from helm-unittest to python unittest

(cherry picked from commit 9322f3e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimberman dimberman dimberman approved these changes

@potiuk potiuk Awaiting requested review from potiuk

@turbaszek turbaszek Awaiting requested review from turbaszek

Assignees
No one assigned
Labels
area:dev-tools area:helm-chart Airflow Helm Chart type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Milestone
Airflow 1.10.13
Development

Successfully merging this pull request may close these issues.
4 participants
@mik-laj @OmairK @dimberman @potiuk