Replace JS package toggle w/ pure CSS solution #11035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
approved these changes
Sep 21, 2020
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jun 17, 2021
Some of the versions were outdated and we no longer use `Bootstrap Toggle` as we removed it in apache#11035
kaxil
added a commit
that referenced
this pull request
Jun 18, 2021
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Mar 10, 2022
Some of the versions were outdated and we no longer use `Bootstrap Toggle` as we removed it in apache/airflow#11035 GitOrigin-RevId: 0bdf89cae56dd16cd826c83355968dd676dcb3bc
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jun 4, 2022
Some of the versions were outdated and we no longer use `Bootstrap Toggle` as we removed it in apache/airflow#11035 GitOrigin-RevId: 0bdf89cae56dd16cd826c83355968dd676dcb3bc
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 10, 2022
Some of the versions were outdated and we no longer use `Bootstrap Toggle` as we removed it in apache/airflow#11035 GitOrigin-RevId: 0bdf89cae56dd16cd826c83355968dd676dcb3bc
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Aug 27, 2022
Some of the versions were outdated and we no longer use `Bootstrap Toggle` as we removed it in apache/airflow#11035 GitOrigin-RevId: 0bdf89cae56dd16cd826c83355968dd676dcb3bc
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 4, 2022
Some of the versions were outdated and we no longer use `Bootstrap Toggle` as we removed it in apache/airflow#11035 GitOrigin-RevId: 0bdf89cae56dd16cd826c83355968dd676dcb3bc
aglipska
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 7, 2022
Some of the versions were outdated and we no longer use `Bootstrap Toggle` as we removed it in apache/airflow#11035 GitOrigin-RevId: 0bdf89cae56dd16cd826c83355968dd676dcb3bc
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Dec 7, 2022
Some of the versions were outdated and we no longer use `Bootstrap Toggle` as we removed it in apache/airflow#11035 GitOrigin-RevId: 0bdf89cae56dd16cd826c83355968dd676dcb3bc
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jan 27, 2023
Some of the versions were outdated and we no longer use `Bootstrap Toggle` as we removed it in apache/airflow#11035 GitOrigin-RevId: 0bdf89cae56dd16cd826c83355968dd676dcb3bc
kosteev
pushed a commit
to kosteev/composer-airflow-test-copybara
that referenced
this pull request
Sep 12, 2024
Some of the versions were outdated and we no longer use `Bootstrap Toggle` as we removed it in apache/airflow#11035 GitOrigin-RevId: 0bdf89cae56dd16cd826c83355968dd676dcb3bc
kosteev
pushed a commit
to kosteev/composer-airflow-test-copybara
that referenced
this pull request
Sep 13, 2024
Some of the versions were outdated and we no longer use `Bootstrap Toggle` as we removed it in apache/airflow#11035 GitOrigin-RevId: 0bdf89cae56dd16cd826c83355968dd676dcb3bc
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 17, 2024
Some of the versions were outdated and we no longer use `Bootstrap Toggle` as we removed it in apache/airflow#11035 GitOrigin-RevId: 0bdf89cae56dd16cd826c83355968dd676dcb3bc
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 7, 2024
Some of the versions were outdated and we no longer use `Bootstrap Toggle` as we removed it in apache/airflow#11035 GitOrigin-RevId: 0bdf89cae56dd16cd826c83355968dd676dcb3bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #10953
Freshens up the UI with a more modern looking toggle switch. Unlike the its predecessor, this switch is pure CSS so it does not rely on JavaScript to apply any styling. This remedies the visual jank you would see when loading the page. Removes the old
bootstrap-togglepackage and its baggage.|
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.