Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of quarantined tests is stored in Github Issue #10119

Merged
merged 3 commits into from
Aug 3, 2020

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Aug 2, 2020

This is an automated tracking solution for our Quarantined tests.

Thanks to it we will be able to track the "flakiness of our tests. The status of last 10 test executions for all quarantined runs are kept in in the issue #10118 and once last 10 runs of a test are ""success" we can remove it from Quarantine.

The quarantine test are run now in a separate workflow and repeated 4 times a day on schedule.

I hope this way we will be able to clean-up the tests quickly.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@turbaszek
Copy link
Member

Should we add in #10118 some info about the process and the issue itself?

@potiuk
Copy link
Member Author

potiuk commented Aug 3, 2020

Good Point. I will add it :)

Copy link
Member

@feluelle feluelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Should we auto-close the issue if no quarantine tests left? And can we only run this action as long as the related issue is open? So it won't run extra actions.

@potiuk
Copy link
Member Author

potiuk commented Aug 3, 2020

I've added a few things:

  1. Documentation in CI.rst
  2. Added header to the issue explaining how it gets updated.
  3. added a "Comment" section that is preserved (so you can for example add link to issue if you are working on flaky test)
  4. added configurable ISSUE_ID -> we need different set of tests for master/v1-10-test/v1-10-stable

@feluelle -> I think we should not close it - flaky tests will happen sooner or later. But indeed closing/opening the issue might be a good idea indeed.

@potiuk
Copy link
Member Author

potiuk commented Aug 3, 2020

I would still run the action anyway - it's not too costly one, and also we should re-open the issue if we add a new quarantined test - so the action (if at all) should be based on a number of tests that we mark as quarantined (so leaving it as is is best)

@potiuk
Copy link
Member Author

potiuk commented Aug 3, 2020

@feluelle -> auto-closing/opening added :)

@potiuk potiuk merged commit 86d8e34 into apache:master Aug 3, 2020
@potiuk potiuk deleted the quarantined-tests branch August 3, 2020 18:01
potiuk added a commit to potiuk/airflow that referenced this pull request Sep 14, 2020
potiuk added a commit that referenced this pull request Sep 15, 2020
RaviTezu pushed a commit to RaviTezu/airflow that referenced this pull request Oct 25, 2020
kaxil pushed a commit that referenced this pull request Nov 12, 2020
@potiuk potiuk added the type:misc/internal Changelog: Misc changes that should appear in change log label Nov 14, 2020
@potiuk potiuk added this to the Airflow 1.10.13 milestone Nov 14, 2020
potiuk added a commit that referenced this pull request Nov 16, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants