-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status of quarantined tests is stored in Github Issue #10119
Conversation
Should we add in #10118 some info about the process and the issue itself? |
Good Point. I will add it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Should we auto-close the issue if no quarantine tests left? And can we only run this action as long as the related issue is open? So it won't run extra actions.
I've added a few things:
@feluelle -> I think we should not close it - flaky tests will happen sooner or later. But indeed closing/opening the issue might be a good idea indeed. |
I would still run the action anyway - it's not too costly one, and also we should re-open the issue if we add a new quarantined test - so the action (if at all) should be based on a number of tests that we mark as quarantined (so leaving it as is is best) |
@feluelle -> auto-closing/opening added :) |
(cherry picked from commit 86d8e34)
(cherry picked from commit 86d8e34)
(cherry picked from commit 86d8e34)
(cherry picked from commit 86d8e34)
(cherry picked from commit 86d8e34)
(cherry picked from commit 86d8e34)
This is an automated tracking solution for our Quarantined tests.
Thanks to it we will be able to track the "flakiness of our tests. The status of last 10 test executions for all quarantined runs are kept in in the issue #10118 and once last 10 runs of a test are ""success" we can remove it from Quarantine.
The quarantine test are run now in a separate workflow and repeated 4 times a day on schedule.
I hope this way we will be able to clean-up the tests quickly.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.