Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airflow dags list-jobs missing state metavar and choices keyword arguments #31303

Closed
2 tasks done
jgarte opened this issue May 15, 2023 · 5 comments
Closed
2 tasks done

Comments

@jgarte
Copy link

jgarte commented May 15, 2023

What do you see as an issue?

The --state CLI flag on airflow dags list-jobs does not tell the user what arguments it can take.

ARG_STATE = Arg(("--state",), help="Only list the dag runs corresponding to the state")

It probably needs some keyword args similar to the following:

 metavar="(table, json, yaml, plain)",
 choices=("table", "json", "yaml", "plain"),

Solving the problem

The problem can be solved by adding those keyword arguments so that the user gets a suggestion for what state arguments can be passed in.

Anything else

Any suggestions on what can be a valid state would be much appreciated. Otherwise, I'll find some time to read through the code and/or docs and figure it out.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@jgarte jgarte added kind:bug This is a clearly a bug kind:documentation needs-triage label for new issues that we didn't triage yet labels May 15, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented May 15, 2023

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

rohan472000 added a commit to rohan472000/airflow that referenced this issue May 16, 2023
@rohan472000
Copy link
Contributor

@jgarte look #31308

@pankajastro pankajastro added area:CLI good first issue and removed needs-triage label for new issues that we didn't triage yet labels May 16, 2023
rohan472000 added a commit to rohan472000/airflow that referenced this issue May 16, 2023
rohan472000 added a commit to rohan472000/airflow that referenced this issue May 16, 2023
@rohan472000
Copy link
Contributor

@pankajastro as #31308 is merged so, you can close this issue.

@pankajastro
Copy link
Member

@pankajastro as #31308 is merged so, you can close this issue.

closed. But you can link your PR with an issue like closes: #ISSUE_NUM that would automatically close the issue when PR will get merged.

@rohan472000
Copy link
Contributor

Oh yes...I forgot to do that..thanks for closing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants