Skip to content

Commit

Permalink
apply reviews from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
ephraimbuddy committed Jan 2, 2022
1 parent 7e8d50a commit 4f4ef54
Showing 1 changed file with 13 additions and 6 deletions.
19 changes: 13 additions & 6 deletions airflow/utils/timezone.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# under the License.
#
import datetime as dt
from typing import TYPE_CHECKING, Optional, Union, overload
from typing import Optional, Union, overload

import pendulum
from dateutil.relativedelta import relativedelta
Expand All @@ -28,9 +28,6 @@
# UTC time zone as a tzinfo instance.
utc = pendulum.tz.timezone('UTC')

if TYPE_CHECKING:
pass


def is_localized(value):
"""
Expand Down Expand Up @@ -106,6 +103,11 @@ def make_aware(value: None, timezone: Optional[dt.tzinfo] = None) -> None:
...


@overload
def make_aware(value: DateTime, timezone: Optional[dt.tzinfo] = None) -> DateTime:
...


@overload
def make_aware(value: dt.datetime, timezone: Optional[dt.tzinfo] = None) -> dt.datetime:
...
Expand Down Expand Up @@ -199,11 +201,16 @@ def coerce_datetime(v: None) -> None:


@overload
def coerce_datetime(v: dt.datetime) -> dt.datetime:
def coerce_datetime(v: DateTime) -> DateTime:
...


@overload
def coerce_datetime(v: dt.datetime) -> DateTime:
...


def coerce_datetime(v: Optional[dt.datetime]) -> Optional[dt.datetime]:
def coerce_datetime(v: Optional[dt.datetime]) -> Optional[DateTime]:
"""Convert whatever is passed in to an timezone-aware ``pendulum.DateTime``."""
if v is None:
return None
Expand Down

0 comments on commit 4f4ef54

Please sign in to comment.