Skip to content

Conversation

kartg
Copy link
Contributor

@kartg kartg commented Mar 28, 2024

The jrms-1.1 library has not seen any releases/updates since 2005 and Maven lists only ActiveMQ and Apache Camel as upstream usages.

After digging through ActiveMQ's mailing lists and commit history, I found that it used to be listed on ActiveMQ's URI Protocols page, but was removed at some point. JRMS seems to be listed as a peer-to-peer option on the topologies page but is not discussed in either the peer or multicast transport reference pages.

The META-INF/services/org/apache/activemq/transport folder under activemq-client (tested using v5.18.3) does not have a "jrms" file, so "jrms://" does not resolve to a supported ActiveMQ protocol.

More details in the JIRA issue - https://issues.apache.org/jira/browse/AMQ-9469

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
@jbonofre jbonofre self-requested a review March 28, 2024 19:53
@kartg kartg marked this pull request as ready for review March 29, 2024 03:27
@jbonofre jbonofre merged commit f90c10d into apache:main Apr 11, 2024
@kartg
Copy link
Contributor Author

kartg commented Apr 11, 2024

thank you @jbonofre! Two follow-up questions:

  1. Do you think this is safe to backport to the 5.18.x branch? IMO it should be safe since the jrms protocol is currently unused even in v5.18.x clients.
  2. What's the right way to update the topologies documentation to remove the reference to JRMS?

@jbonofre
Copy link
Member

@kartg

  1. Yes, I don't see problem to cherry-pick on activemq-5.18.x, I will do that
  2. To update website, you have to open a PR on https://github.com/apache/activemq-website

@jbonofre
Copy link
Member

@kartg I cherry-picked the commit for activemq-5.18.x branch.

@kartg
Copy link
Contributor Author

kartg commented Apr 12, 2024

Thank you! In future, would you prefer that requestors submit the backport PR so you don't have to manage it?

Possibly useful - there's also a backport GH action which I've used on other projects that can automate backports based on labels.

@jbonofre
Copy link
Member

@kartg we ask the contributor to open the PR on main branch only. Then the committer/reviewer merge and cherry-pick on branches where it makes sense. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants