Fixes a Fate bug (part 2) #4994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes an issue with how Fates WorkFinder handles InterruptedExceptions which can lead to an infinite error loop and leave the WorkFinder broken
Merged
keith-turner
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes an issue with how Fates
WorkFinderhandlesInterruptedExceptions which can lead to an infinite error loop and leave theWorkFinderbrokenI'm wondering if this is a problem elsewhere as there are many places that handle an
InterruptedExceptionthe same wayThe conversation which brought about this PR was from:
#4965
This PR in conjunction with #4965 close #4906