Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize EE dependencies #1947

Merged
merged 4 commits into from
Feb 25, 2021
Merged

Modernize EE dependencies #1947

merged 4 commits into from
Feb 25, 2021

Conversation

ctubbsii
Copy link
Member

Update Java EE dependencies to Jakarta EE 9

  • Update dependencies in pom.xml
  • Update import statements (javax.* to jakarta.*)
  • Update jetty to 11 (very minor edit required in EmbeddedWebServer to
    fix a variable's assigned type to match the constructed instance type)
  • Update jersey to 3
  • Update hibernate-validator to 7
  • Use bom for dependency management for jakartaee, jetty, jersey, hk2,
    jackson, and jaxb
  • Remove unnecessary maven-dependency-plugin warning suppressions in
    pom.xml
  • Minimize bundled jars, removing any that did not appear to be required
    for functionality

Additionally, fix #1898 by updating LICENSE/NOTICE files while updating
dependencies:

  • Relocate ellipsis datatables plugin and jquery to subdirectories to
    make it easier to reference in LICENSE and associate with distinct
    upstream sources for future updates
  • Remove unused select2.css
  • Review all bundled external resources (js/css) for monitor and update
    LICENSE and NOTICE files accordingly
  • Review all bundled jars in lib directory of binary tarball and update
    LICENSE and NOTICE files accordingly
  • Standardize the structure of the LICENSE/NOTICE files to avoid
    duplication of external license texts where possible (especially for
    EPL-2.0, which is massive) and to use the Maven coordinates from
    component.xml for easier maintenance

 Update Java EE dependencies to Jakarta EE 9

* Update dependencies in pom.xml
* Update import statements (`javax.*` to `jakarta.*`)
* Update jetty to 11 (very minor edit required in EmbeddedWebServer to
  fix a variable's assigned type to match the constructed instance type)
* Update jersey to 3
* Update hibernate-validator to 7
* Use bom for dependency management for jakartaee, jetty, jersey, hk2,
  jackson, and jaxb
* Remove unnecessary maven-dependency-plugin warning suppressions in
  pom.xml
* Minimize bundled jars, removing any that did not appear to be required
  for functionality

Additionally, fix apache#1898 by updating LICENSE/NOTICE files while updating
dependencies:

* Relocate ellipsis datatables plugin and jquery to subdirectories to
  make it easier to reference in LICENSE and associate with distinct
  upstream sources for future updates
* Remove unused select2.css
* Review all bundled external resources (js/css) for monitor and update
  LICENSE and NOTICE files accordingly
* Review all bundled jars in lib directory of binary tarball and update
  LICENSE and NOTICE files accordingly
* Standardize the structure of the LICENSE/NOTICE files to avoid
  duplication of external license texts where possible (especially for
  EPL-2.0, which is massive) and to use the Maven coordinates from
  `component.xml` for easier maintenance
@ctubbsii ctubbsii self-assigned this Feb 24, 2021
@ctubbsii
Copy link
Member Author

ctubbsii commented Feb 24, 2021

There is a bug with MonitorSslIT with this on my machine, that I'm trying to track down. It seems that there's a mismatch in the way the new SSL handling code on the server identifies the certificate to present and the way our http client code in the test initiates the request, that causes the client to pass SNI information (which the client sets to null) that prevents the test server from satisfying the request. I'm still tracking this down.

EDIT: fixed in newer commits

Use the name in the test SSL certificates for minicluster's monitor that
matches the name of the host on which the monitor is listening.

This fixes bugs in the SSL context that prevents test code from
connecting to the monitor because of an SNI name mismatch.
@ctubbsii
Copy link
Member Author

I created FasterXML/jackson-bom#40 to deal with the fact that I couldn't use the jackson bom for managing some of the Jakarta EE variants of jackson libraries.

@ctubbsii ctubbsii merged commit 701e179 into apache:main Feb 25, 2021
@ctubbsii ctubbsii deleted the update-deps branch February 25, 2021 07:06
@ctubbsii ctubbsii added this to the 2.1.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License and notice review for 2.x
1 participant