This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
feat(core): add support for non-temporal series limit #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/2gx3XZ76mr7RdZb7C12VLrfc3vfr |
villebro
force-pushed
the
villebro/boxplot-series-limit
branch
from
a23ed3d
to
8c7b54e
Compare
9 tasks
villebro
force-pushed
the
villebro/boxplot-series-limit
branch
from
8c7b54e
to
1331d43
Compare
villebro
force-pushed
the
villebro/boxplot-series-limit
branch
from
1331d43
to
83c563e
Compare
villebro
force-pushed
the
villebro/boxplot-series-limit
branch
from
83c563e
to
bb2f797
Compare
villebro
force-pushed
the
villebro/boxplot-series-limit
branch
from
bb2f797
to
4cb0260
Compare
Codecov Report
@@ Coverage Diff @@
## master #1356 +/- ##
==========================================
+ Coverage 30.03% 30.05% +0.01%
==========================================
Files 489 489
Lines 9854 9859 +5
Branches 1654 1657 +3
==========================================
+ Hits 2960 2963 +3
Misses 6653 6653
- Partials 241 243 +2
Continue to review full report at Codecov.
|
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
villebro
changed the title
kgabryje
reviewed
Sep 10, 2021
zhaoyongjie
suggested changes
Sep 14, 2021
|
Thanks all for the input and reviews! Looking forward to help make generic x-axis happen! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
Currently it is impossible to restrict the number of series in non-temporal charts. This adds three new
QueryFormandQueryObjectproperties, along with relevant shared controls for them:series_columns: the columns to group by when limiting series (previously always assumed to be all groupby columns except the temporal column). This can be leftundefined/[], in which case series limiting won't happen.series_limit: to replacetimeseries_limitseries_limit_metric: to replacetimeseries_limit_metricAs a POC, this functionality is implemented on the BoxPlot chart where this functionality was mostly broken (only working if distribution was across temporal column).
Related PR on
apache/superset: apache/superset#16660AFTER
Here we've defined a non-temporal series limit column
countrieswith a limit of 5 series, and the chart renders correctly with the top 5 regions:BEFORE
Before the x-axis would populate more than the specified 5 series:
