Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore: New feature flag #1178

Closed
wants to merge 4 commits into from

Conversation

AAfghahi
Copy link
Contributor

💔 Breaking Changes

🏆 Enhancements

📜 Documentation

🐛 Bug Fix

🏠 Internal
Changing the name to better reflect what the feature flag is doing.

@AAfghahi AAfghahi requested a review from a team as a code owner June 17, 2021 18:50
@vercel
Copy link

vercel bot commented Jun 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/4pCDiFvhpq5tyanAixgeKEAbfWVu
✅ Preview: https://superset-ui-git-fork-preset-io-newfeatureflag-superset.vercel.app

@hughhhh
Copy link
Contributor

hughhhh commented Jun 17, 2021

@suddjian is this a breaking change we change the name of a feature flag?

@hughhhh hughhhh requested review from suddjian and nytai June 17, 2021 18:59
@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #1178 (ce30cc3) into master (7aec0a4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1178   +/-   ##
=======================================
  Coverage   29.01%   29.01%           
=======================================
  Files         463      463           
  Lines        9338     9338           
  Branches     1493     1493           
=======================================
  Hits         2709     2709           
  Misses       6418     6418           
  Partials      211      211           
Impacted Files Coverage Δ
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aec0a4...ce30cc3. Read the comment docs.

@suddjian
Copy link
Member

IMO this should be considered a breaking change (see SIP 57). It could be made a non-breaking change if measures are taken to make it so that the old name still works.

@AAfghahi
Copy link
Contributor Author

@suddjian currently only one place in superset is using this featureFlag, and it is the database connection ui.

@eschutho
Copy link
Contributor

@AAfghahi I would recommend adding the new flag instead of changing the name. You can remove the old flag later- mark that it is deprecated.

@villebro
Copy link
Contributor

The codebase on this repo has been moved to the main Apache Superset repo, and consequently the repo is in the process of being archived. See the Superset Improvement Proposal for details: apache/superset#13013 . While all currently open issues and PRs will be closed, we encourage you to reopen this PR on the main repo, which should be as simple as moving over any code changes as follows:

  • core packages: packages/** (this repo) -> superset-frontend/packages/** (main repo)
  • plugins: plugins/** (this repo) -> superset-frontend/plugins/** (main repo)

If you need help with the migration, please post a message on the SIP or reach out on the community Slack.

@villebro villebro closed this Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants