Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat: add plugin for Kepler #2

Merged
merged 4 commits into from
Oct 21, 2019
Merged

feat: add plugin for Kepler #2

merged 4 commits into from
Oct 21, 2019

Conversation

mistercrunch
Copy link
Contributor

@mistercrunch mistercrunch commented Oct 2, 2019

Trying to create plugin for kepler migrating the code from apache/superset#6403

Hitting a blocker:
Screen Shot 2019-10-01 at 10 36 42 PM

Has to do with this line:
https://github.com/uber-web/type-analyzer/blob/master/src/utils.js#L106

I'm confused by the error, and guessing that our babel configuration doesn't like pre-ES6 imports. Also a bit confused by the symlinking and why the import of type-analyzer wouldn't use some compiled version of that lib...

@mistercrunch mistercrunch requested a review from a team as a code owner October 2, 2019 05:37
@netlify
Copy link

netlify bot commented Oct 2, 2019

Deploy preview for superset-ui-plugins-deckgl ready!

Built with commit b3a7c06

https://deploy-preview-2--superset-ui-plugins-deckgl.netlify.com

@kristw
Copy link
Collaborator

kristw commented Oct 2, 2019

If Kepler will be the only plugin in this preset you could make this be legacy-plugin-chart-kepler.
See https://github.com/apache-superset/superset-ui-plugins-template/tree/master/packages for examples

@kristw
Copy link
Collaborator

kristw commented Oct 2, 2019

For the error, if you can yarn build in this repo successfully then it will have to do with webpack config in incubator-superset.

Look for this line in webpack.config.js in incubator-superset and add type-analyzer to include regex.

        // handle symlinked modules
        // for debugging @superset-ui packages via npm link

Anyway, if you can yarn build successfully, this should affect only testing with npm link but not affect when importing the package normally after it has been published to npm.

@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master    #2   +/-   ##
====================================
  Coverage      75%   75%           
====================================
  Files           1     1           
  Lines           4     4           
====================================
  Hits            3     3           
  Misses          1     1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update defa6a1...b3a7c06. Read the comment docs.

@khtruong
Copy link
Contributor

👀 @mistercrunch @betodealmeida

Copy link

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khtruong khtruong merged commit ad90d48 into master Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants