[chrome] accumulated patches in one PR #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wang Chen <wangchen20@iscas.ac.cn>
Signed-off-by: Wang Chen <wangchen20@iscas.ac.cn>
unicornx
changed the title
Signed-off-by: Wang Chen <wangchen20@iscas.ac.cn>
unicornx
force-pushed
the
dev-chrome-build
branch
from
86284b8 to
16bbbd3
Compare
McKnight22
reviewed
Feb 25, 2023
| android_static_analysis=\"off\" \ | ||
| clang_use_chrome_plugins=false \ | ||
| clang_base_path=\"/aosp/common/wangchen/llvm-build/Release+Asserts\" \ | ||
| clang_use_chrome_plugins=false \ |
There was a problem hiding this comment.
Please remove the duplicated line "clang_use_chrome_plugins=false".
Signed-off-by: Wang Chen <wangchen20@iscas.ac.cn>
unicornx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 3 patches:
cb19031: use args to set default_min_sdk_version
default_min_sdk_version maybe changed during android developement process, so we should better not fix it in code, for all ARCH (including riscv64).
for example, let's use
gn --args="default_min_sdk_version=10000"eac959f: use __cxa_thread_atexit_impl() from bionic for riscv64
bionic has implemented __cxa_thread_atexit_impl() and provide it since API level 23, just use it to pass building
of libc++, otherwise it will report some __thread variables undefined
16bbbd3: added one make file just for internal dev
To make life easy.