[chrome] rollback to use API level 24 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running on board, got crash report from
libVkLayer_khronos_validation.cr.so.
Compared with arm64, this lib is not loaded and found in
third_party/angle/gni/angle.gni
```
# Vulkan Validation Layers require Android NDK API level 26, i.e.
Oreo, due to
# Vulkan Validation Layers compatibility issues, see
http://crrev/c/1405714.
angle_enable_vulkan_validation_layers =
angle_enable_vulkan && !is_ubsan && !is_tsan && !is_asan &&
angle_debug_layers_enabled && (!is_android ||
ndk_api_level_at_least_26)
```
arm64 will not load libVkLayer_khronos_validation.cr.so becasue it use
24 as default api level, but we use 29, that makes the lib is loaded for
us and crash it due to the lib is not ready for us now.
Solution: do the same now as amd64, and use 24 as default api level.
This requires modification accordingly in ndk. So I update the android
ndk by manual, just copied 29 and renamed it to 24.
FIXME: this may not the best solution, just workaround the crash and
move forward.
With API level rollback to 24, reverted change in skia to not link
libEGL and etc.
Signed-off-by: Wang Chen <wangchen20@iscas.ac.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on board, got crash report from
libVkLayer_khronos_validation.cr.so.
Compared with arm64, this lib is not loaded and found in third_party/angle/gni/angle.gni
arm64 will not load libVkLayer_khronos_validation.cr.so becasue it use 24 as default api level, but we use 29, that makes the lib is loaded for us and crash it due to the lib is not ready for us now.
Solution: do the same now as amd64, and use 24 as default api level. This requires modification accordingly in ndk. So I update the android ndk by manual, just copied 29 and renamed it to 24. FIXME: this may not the best solution, just workaround the crash and move forward.
With API level rollback to 24, reverted change in skia to not link libEGL and etc.