Skip to content

Commit

Permalink
FIXME -> FIXEME(riscv64-android)
Browse files Browse the repository at this point in the history
make it easy to search our FIXME.

Signed-off-by: Wang Chen <wangchen20@iscas.ac.cn>
  • Loading branch information
unicornx committed Mar 10, 2023
1 parent e291982 commit 28f5031
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ distclean:
rm -rf out/$(ARCH)

# make gn [ARCH=<xxx>] [CLANG=<xxx>]
# FIXME:
# FIXME(riscv64-android):
# "clang_use_chrome_plugins=false" may not be required when we are using
# clang for Chrome built by ourselves.
.PHONY: gn
Expand Down
2 changes: 1 addition & 1 deletion build/config/android/abi.gni
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ if (target_cpu == "arm64") {
android_secondary_abi_cpu = "mipsel"
android_app_secondary_abi = "mips"
} else if (target_cpu == "riscv64") {
# FIXME: In origianl design, every 64-bit ARCH defaultly owns itself 32-bit
# FIXME(riscv64-android): In origianl design, every 64-bit ARCH defaultly owns itself 32-bit
# second abi and will handle 2nd abi here and there.
# But for riscv64, we don't want to support riscv32. To not change too much,
# currently we just define pseudo 2nd abi here to pass gn build.
Expand Down
2 changes: 1 addition & 1 deletion build/toolchain/android/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ android_clang_toolchain("android_clang_riscv64") {
}
}

# FIXME: define pseudo toolchain for 2nd abi here, just to pass gn build.
# FIXME(riscv64-android): define pseudo toolchain for 2nd abi here, just to pass gn build.
# Details refer to comments in build/config/android/abi.gni about 2nd abi
# handling.
android_clang_toolchain("android_clang_riscv32") {
Expand Down
2 changes: 1 addition & 1 deletion build/util/android_chrome_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@
'64_32': 7,
'64': 8,
},
# FIXME: just do the same as "intel"
# FIXME(riscv64-android): just do the same as "intel"
# Not sure the value if correct for chrome.
'riscv': {
'32': 2,
Expand Down
2 changes: 1 addition & 1 deletion skia/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ component("skia") {
libs = [ "fontsub.lib" ]
}

# FIXME:
# FIXME(riscv64-android):
# third_party/skia/src/gpu/ganesh/GrAHardwareBufferUtils.cpp
# which will call APIs from EGL/GLESv2 when built for android
# and API level >= 26
Expand Down

0 comments on commit 28f5031

Please sign in to comment.