Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip single selection for artist actions #507

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

aNNiMON
Copy link
Contributor

@aNNiMON aNNiMON commented Jul 17, 2024

Since most tracks are performed by a single artist, I found it a bit annoying to always select an artist when using the GoToArtist and ShowActionsOnArtist actions.

@aNNiMON aNNiMON force-pushed the skip-single-selection branch 2 times, most recently from c63ef30 to ea2f809 Compare July 17, 2024 18:51
Copy link
Owner

@aome510 aome510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice QoL improvement. Few nits left.

spotify_player/src/event/mod.rs Outdated Show resolved Hide resolved
spotify_player/src/event/mod.rs Outdated Show resolved Hide resolved
album.artists,
new_list_state(),
));
self::handle_show_actions_on_artist(album.artists, data, ui);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self::handle_show_actions_on_artist(album.artists, data, ui);
handle_show_actions_on_artist(album.artists, data, ui);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I wonder why CI doesn't detect it?

spotify_player/src/event/mod.rs Outdated Show resolved Hide resolved
@aome510 aome510 merged commit 04f08f9 into aome510:master Jul 19, 2024
3 checks passed
DOD-101 pushed a commit to DOD-101/spotify-player that referenced this pull request Jul 19, 2024
juliamertz pushed a commit to juliamertz/spotify-player that referenced this pull request Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants