Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #464 by adding full date to display next to albums #474

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

DOD-101
Copy link
Contributor

@DOD-101 DOD-101 commented Jun 25, 2024

fixes #464

This PR removes the code previously responsible for filtering out duplicate album names, which had caused #464.

I have decided to not any additional text to signal the difference between the albums with the same name as:

  1. That might cause confusion as the the actual name of the album
  2. There is in my opinion no problem with having 2 entries with the same name
  3. The official Spotify client also handles this situation in this manner

This PR however doesn't entirely fix the bug described in the issue, as it seems that this is an upstream issue. The Spotify API doesn't return both copies of the album "Revelations" by "Audioslave" and accordingly the Spotify Client has the exact same behavior as spotfiy_player. But now the two versions of Original Fire show up as they should.

Spotify response sample:

jq '.items[].name' response.json

"Revelations"
"Out of Exile"
"Audioslave"
"Original Fire"
"Original Fire"
"Doesn't Remind Me"
"Sessions @AOL Music - EP (Live)"
"Your Time Has Come"
"Like A Stone (Live from New York City)"
"Be Yourself"
"Audioslave Live on Hollywood Blvd."
"Show Me How To Live"
"Cochise"
"Chris Cornell (Deluxe Edition)"
"Live 8 (Live, July 2005)"
"Rock Clássico"
"90s Grunge"
"Canciones De Hace Un Tiempo - Rock"
"20 Top Rock Hits"
"Summer Rocks Best Buy Version"
"Miami Ibiza St. Tropez, Selected Housetunes Vol. 1"

This commit removes the code previously responsable for filtering
out duplicate album names.
@aome510
Copy link
Owner

aome510 commented Jun 26, 2024

I have decided to not any additional text to signal the difference between the albums with the same name as:

That might cause confusion as the the actual name of the album
There is in my opinion no problem with having 2 entries with the same name
The official Spotify client also handles this situation in this manner

Maybe you can add album_type and render it in UI to better differentiate between albums of the same name. Official Spotify app does this.

Another approach would be updating the UI to render the full date instead of just year.

Otherwise, it will be confusing to me if I see duplicated entries.

@DOD-101
Copy link
Contributor Author

DOD-101 commented Jun 27, 2024

Here are the two options you suggested:

image

This one doesn't fix the issue of ambiguity you addressed.

image

This is, in my opinion, too much detail / text if you are just looking for an album.

+ two other options

image

This doesn't directly show the exact distinction between the two albums, but does at least show that there is some kind of difference.

Another possible solution would be to display the number of songs in an album. This is probably the most preferable solution, as it would in most cases signal a clear difference between the different versions without adding too much info or text that might not be useful to the end user just looking for an album.

The only problem I have with 4 is that SimplifiedAlbum doesn't contain tracks.

@aome510
Copy link
Owner

aome510 commented Jun 27, 2024

Here are the two options you suggested:

image

This one doesn't fix the issue of ambiguity you addressed.

image

This is, in my opinion, too much detail / text if you are just looking for an album.

  • two other options

image

This doesn't directly show the exact distinction between the two albums, but does at least show that there is some kind of difference.

Another possible solution would be to display the number of songs in an album. This is probably the most preferable solution, as it would in most cases signal a clear difference between the different versions without adding too much info or text that might not be useful to the end user just looking for an album.

The only problem I have with 4 is that SimplifiedAlbum doesn't contain tracks.

Thanks for the investigation. Really helpful. I would probably go with 2 as it might also help with filtering in case you want to find specific album.

DOD-101 and others added 2 commits June 28, 2024 18:51
This change resolves the ambiguity between different
Albums of the same Name.
@DOD-101 DOD-101 changed the title fix #464 by removing code to filter duplicates fix #464 by adding full date to display next to Albums Jun 28, 2024
@DOD-101 DOD-101 changed the title fix #464 by adding full date to display next to Albums fix #464 by adding full date to display next to albums Jun 28, 2024
@aome510 aome510 merged commit a7ba31a into aome510:master Jun 28, 2024
3 checks passed
juliamertz pushed a commit to juliamertz/spotify-player that referenced this pull request Jul 20, 2024
…0#474)

* fix aome510#464 by removing code to filter duplicates

This commit removes the code previously responsable for filtering
out duplicate album names.

* Display full date next to Albums on Artist page

This change resolves the ambiguity between different
Albums of the same Name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artist's albums of the same year disappear
2 participants