Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional fuzzy search algorithm #468

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Conversation

juliamertz
Copy link
Contributor

I discovered that the current search algorithm struggles with queries that start with a single letter followed by a space. To address this issue, I've added a new feature flag that enables fuzzy searching. This makes searching a lot more flexible and also sorts the results by their relevance.

This is my first time using feature flags, so I am open to feedback on the control flow implementation.

update readme

sort search results by score

uncomment feature blocks

fix
Copy link
Owner

@aome510 aome510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, LGTM!

spotify_player/src/state/ui/mod.rs Show resolved Hide resolved
spotify_player/src/state/ui/mod.rs Outdated Show resolved Hide resolved
jorismertz and others added 2 commits June 17, 2024 21:24
Co-authored-by: Thang Pham <phamducthang1234@gmail.com>
@juliamertz
Copy link
Contributor Author

Accidentally included a commit i did not mean to.

@aome510
Copy link
Owner

aome510 commented Jun 18, 2024

Look like CI failed but it's unrelated to your change. I can take a look and fix later today

@aome510 aome510 merged commit 0cdf815 into aome510:master Jun 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants