Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add album to queue action #429

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Conversation

nikosavola
Copy link
Contributor

@nikosavola nikosavola commented Apr 24, 2024

Hi @aome510,

I'm new to Rust bu tried implementing the Add album to queue action but could not get the development version working locally. I'm left with a blank screen when running the binary even from master after cargo build. Do you need to do something else or is the master failing? I have a release version authenticated with spotify and working.

Are there any additional places we need to add AddAlbumToQueue, AddToQueue and the AddSelectedItemToQueue for supporting keymapped queue.

Drafted until ready.

Closes #407

@aome510
Copy link
Owner

aome510 commented Apr 24, 2024

I think it might be related to #424. Pushed a commit to temporarily fix the change. Can you merge main and try again?

@aome510
Copy link
Owner

aome510 commented Apr 24, 2024

You can either look into the application's log or backtrace inside ~/.cache/spotify-player/ to see if there is any error/panic.

Copy link
Owner

@aome510 aome510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

@aome510 aome510 marked this pull request as ready for review April 26, 2024 20:46
@aome510 aome510 merged commit ba133a8 into aome510:master Apr 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add album to queue
2 participants