build: use cross for cross-compilation, locally and in CD
#343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the intention of migrating gh action to native solution with cross Supported targets: aarch-64-linux-gnu, armv7-unknown-linux-gnueabihf Use cross build --target (target) Note: docker base images have been updated. See related documentation: https://github.com/cross-rs/cross/wiki/FAQ#custom-images
Update container images along with it. Also a couple actions. Use action-rs/cargo only for the built in support. It is the documented gh actions way in the cross README. Manually would probably increase times significantly.
LucasFA
force-pushed
the
cross-compile
branch
from
26ce9de
to
e73e938
Compare
LucasFA
added a commit
to LucasFA/hackernews-TUI
that referenced
this pull request
Jan 27, 2024
* build: local cross compilation With the intention of migrating gh action to native solution with cross Supported targets: aarch-64-linux-gnu, armv7-unknown-linux-gnueabihf Use cross build --target (target) Note: docker base images have been updated. See related documentation: https://github.com/cross-rs/cross/wiki/FAQ#custom-images * build(cd): use cross for CD Update container images along with it. Also a couple actions. Use action-rs/cargo only for the built in support. It is the documented gh actions way in the cross README. Manually would probably increase times significantly. See aome510/spotify-player#343
aome510
added a commit
to aome510/hackernews-TUI
that referenced
this pull request
Feb 12, 2024
* Update CD workflows to use use `cross` * build: local cross compilation With the intention of migrating gh action to native solution with cross Supported targets: aarch-64-linux-gnu, armv7-unknown-linux-gnueabihf Use cross build --target (target) Note: docker base images have been updated. See related documentation: https://github.com/cross-rs/cross/wiki/FAQ#custom-images * build(cd): use cross for CD Update container images along with it. Also a couple actions. Use action-rs/cargo only for the built in support. It is the documented gh actions way in the cross README. Manually would probably increase times significantly. See aome510/spotify-player#343 --------- Co-authored-by: Thang Pham <phamducthang1234@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: of each commit is in order:
cross.Major significant benefit it actually just using current images - the FROM in the Dockerfile resolves to
ghcr.io/cross-rs/aarch64-unknown-linux-gnu:latest. That by itself could have been a PR.By the way, to see that TLDR in the code I recommend checking each commit individually. Both together it just looks like a mess 🙃